Re: [PATCH v2] mtd: onenand: omap2: add dependency on GPMC

From: Miquel Raynal
Date: Mon Nov 07 2022 - 11:20:35 EST


On Mon, 2022-11-07 at 09:15:20 UTC, Krzysztof Kozlowski wrote:
> OMAP2 OneNAND driver uses gpmc_omap_onenand_set_timings() provided by
> OMAP_GPMC driver, so the latter cannot be module if OneNAND driver is
> built-in:
>
> /usr/bin/arm-linux-gnueabi-ld: drivers/mtd/nand/onenand/onenand_omap2.o: in function `omap2_onenand_probe':
> onenand_omap2.c:(.text+0x520): undefined reference to `gpmc_omap_onenand_set_timings'
>
> The OMAP_GPMC is also a runtime dependency.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Fixes: 854fd9209b20 ("memory: omap-gpmc: Allow building as a module")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel