Re: [PATCH v2] x86/acrn: Set X86_FEATURE_TSC_KNOWN_FREQ

From: Borislav Petkov
Date: Mon Nov 07 2022 - 10:30:44 EST


On Tue, Nov 01, 2022 at 01:30:19PM +0800, Fei Li wrote:
> If the TSC frequency is known from the acrn_get_tsc_khz(),
> the TSC frequency does not need to be recalibrated.

What if the HV has unstable TSCs? How do you handle that?

> Avoiding recalibration by setting X86_FEATURE_TSC_KNOWN_FREQ.

Pls read section "2) Describe your changes" in
Documentation/process/submitting-patches.rst for more details on how to
write your commit message.

> This patch also removes `inline` for acrn_get_tsc_khz() since
> it doesn't make sense.

Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.

Also, do

$ git grep 'This patch' Documentation/process

for more details.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette