RE: [PATCH v11 1/2] thermal: Add thermal driver for Sunplus

[Lh Kuo 郭力豪]

Thank you  I will fix it in next next submission

> -----Original Message-----
> From: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Sent: Sunday, October 23, 2022 12:36 AM
> To: Li-hao Kuo <lhjeff911@xxxxxxxxx>; krzk@xxxxxxxxxx; rafael@xxxxxxxxxx; amitk@xxxxxxxxxx;
> rui.zhang@xxxxxxxxx; robh+dt@xxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Cc: Lh Kuo 郭力豪 <lh.Kuo@xxxxxxxxxxx>
> Subject: Re: [PATCH v11 1/2] thermal: Add thermal driver for Sunplus
> 
> On 18/10/2022 09:32, Li-hao Kuo wrote:
> > Add thermal driver for Sunplus.
> >
> > Signed-off-by: Li-hao Kuo <lhjeff911@xxxxxxxxx>
> > ---
> > Changes in v11:
> >   - Remove the remove function of the platform_driver
> >   - Fix error reported-by: kernel test robot.
> >
> >   MAINTAINERS                       |   6 ++
> >   drivers/thermal/Kconfig           |  10 +++
> >   drivers/thermal/Makefile          |   1 +
> >   drivers/thermal/sunplus_thermal.c | 130 ++++++++++++++++++++++++++++++++++++++
> >   4 files changed, 147 insertions(+)
> >   create mode 100644 drivers/thermal/sunplus_thermal.c
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS index cf0f185..bf22c53 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -19753,6 +19753,12 @@ S:	Maintained
> >   F:	Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> >   F:	drivers/spi/spi-sunplus-sp7021.c
> >
> > +SUNPLUS THERMAL DRIVER
> > +M:	Li-hao Kuo <lhjeff911@xxxxxxxxx>
> > +L:	linux-pm@xxxxxxxxxxxxxxx
> > +S:	Maintained
> > +F:	drivers/thermal/sunplus_thermal.c
> > +
> >   SUNPLUS UART DRIVER
> >   M:	Hammer Hsieh <hammerh0314@xxxxxxxxx>
> >   S:	Maintained
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index
> > e052dae..405b788 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -504,4 +504,14 @@ config KHADAS_MCU_FAN_THERMAL
> >   	  If you say yes here you get support for the FAN controlled
> >   	  by the Microcontroller found on the Khadas VIM boards.
> >
> > +config SUNPLUS_THERMAL
> > +	tristate "Sunplus thermal drivers"
> > +	depends on SOC_SP7021 || COMPILE_TEST
> > +	help
> > +	  This enable the Sunplus SP7021 thermal driver, which supports the primitive
> > +	  temperature sensor embedded in Sunplus SP7021 SoC.
> > +
> > +	  If you have a Sunplus SP7021 platform say Y here and enable this option
> > +	  to have support for thermal management.
> > +
> >   endif
> > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile index
> > 2506c6c..4512193 100644
> > --- a/drivers/thermal/Makefile
> > +++ b/drivers/thermal/Makefile
> > @@ -61,3 +61,4 @@ obj-$(CONFIG_UNIPHIER_THERMAL)	+= uniphier_thermal.o
> >   obj-$(CONFIG_AMLOGIC_THERMAL)     += amlogic_thermal.o
> >   obj-$(CONFIG_SPRD_THERMAL)	+= sprd_thermal.o
> >   obj-$(CONFIG_KHADAS_MCU_FAN_THERMAL)	+= khadas_mcu_fan.o
> > +obj-$(CONFIG_SUNPLUS_THERMAL)	+= sunplus_thermal.o
> > \ No newline at end of file
> > diff --git a/drivers/thermal/sunplus_thermal.c
> > b/drivers/thermal/sunplus_thermal.c
> > new file mode 100644
> > index 0000000..20ea7d9
> > --- /dev/null
> > +++ b/drivers/thermal/sunplus_thermal.c
> > @@ -0,0 +1,130 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright (c) Sunplus Inc.
> > + * Author: Li-hao Kuo <lhjeff911@xxxxxxxxx>  */
> > +
> > +#include <linux/bitfield.h>
> > +#include <linux/clk.h>
> > +#include <linux/delay.h>
> > +#include <linux/io.h>
> > +#include <linux/module.h>
> > +#include <linux/nvmem-consumer.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/reset.h>
> > +#include <linux/thermal.h>
> > +
> > +#define ENABLE_THERMAL		BIT(31)
> > +#define SP_THERMAL_MASK		GENMASK(10, 0)
> > +
> > +#define TEMP_RATE		608
> > +#define TEMP_BASE		3500
> > +#define TEMP_OTP_BASE		1518
> > +
> > +#define SP_THERMAL_CTL0_REG	0x0000
> > +#define SP_THERMAL_STS0_REG	0x0030
> > +
> > +/* common data structures */
> > +struct sp_thermal_data {
> > +	struct thermal_zone_device *pcb_tz;
> > +	void __iomem *regs;
> > +	int *otp_temp0;
> > +};
> > +
> > +static int sunplus_get_otp_temp_coef(struct sp_thermal_data *sp_data,
> > +struct device *dev) {
> > +	struct nvmem_cell *cell;
> > +	ssize_t otp_l;
> > +
> > +	cell = nvmem_cell_get(dev, "calib");
> > +	if (IS_ERR(cell))
> > +		return PTR_ERR(cell);
> > +
> > +	sp_data->otp_temp0 = nvmem_cell_read(cell, &otp_l);
> > +	nvmem_cell_put(cell);
> > +
> > +	if (*sp_data->otp_temp0 == 0)
> > +		*sp_data->otp_temp0 = TEMP_OTP_BASE;
> > +
> > +	return 0;
> > +}
> > +
> > +/*
> > + * There is a thermal sensor instance for Sunplus Soc
> > + * T_CODE is the ADC of the thermal sensor
> > + * T_CODE : 11 digits in total
> > + * When remanufacturing, the 35 degree T_CODE will be read and stored in nvcell.
> > + * otp_temp0 is the 35 degree T_CODE obtained from nvcell
> > + * The function will get 35 degree T_CODE for thermal calibration.
> > + * TEMP_RATE is the Sunplus thermal temperature slope.
> > + */
> > +
> > +static int sp_thermal_get_sensor_temp(void *data, int *temp) {
> > +	struct sp_thermal_data *sp_data = data;
> > +	int t_code;
> > +
> > +	t_code = readl(sp_data->regs + SP_THERMAL_STS0_REG);
> > +	t_code = FIELD_GET(SP_THERMAL_MASK, t_code);
> > +	*temp = ((*sp_data->otp_temp0 - t_code) * 10000 / TEMP_RATE) + TEMP_BASE;
> > +	*temp *= 10;
> > +	return 0;
> > +}
> > +
> > +static const struct thermal_zone_of_device_ops sp_of_thermal_ops = {
> 
> struct thermal_zone_device_ops ...
> 
> 
> https://lore.kernel.org/r/20220804224349.1926752-1-daniel.lezcano@xxxxxxxxxx
> 
> 
> 
> 
> 
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg>
> Twitter | <http://www.linaro.org/linaro-blog/> Blog