Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to timer_shutdown*()

From: Julia Lawall
Date: Sun Nov 06 2022 - 18:09:59 EST




On Sun, 6 Nov 2022, Linus Torvalds wrote:

> On Sun, Nov 6, 2022 at 1:10 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > ... when strict
> > when != ptr->timer.function = E;
>
> .. and I tried this with just 'ptr->timer', and it doesn't seem to
> make any difference, so apparently that NULL pointer initialization
> was the only case.

OK, good to know.

julia

>
> And then - like you and Guenter - I went through the patch manually to
> look for anything that looked odd, and didn't find anything.
>
> So yes, I'm happy with this. It looks like a very reasonable "let's
> handle the scripted trivial cases automatically", and then anything
> more complicated can be left for 6.2.
>
> And with that cocci script (and how to run it), people can see what
> the script was, and even run it themselves to verify, and that just
> makes me feel all warm and fuzzy about it.
>
> Linus
>