Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to timer_shutdown*()

[Guenter Roeck]

On Sun, Nov 06, 2022 at 02:40:14PM -0800, Linus Torvalds wrote:
> On Sun, Nov 6, 2022 at 1:52 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > I can update the change log to include:
> 
> Yup, full running instructions for coccinelle patches is probably a good idea.
> 
> I've done them semi-occasionally, but it's rare enough that I always
> have to look it up anyway, and I suspect many others have never done
> it, so having it in the commit message is probably a good idea.
> 
> >       when != ptr->timer.function = E;
> 
> I do think that you should just remove that E expression and the
> "function = E" part.
> 

Agreed. Removing this line does not make a difference. It looks like the
"when strict" takes care of the condition.

Guenter