Re: [PATCH] HID: hid-sensor-custom: Allow more than one hinge angle sensor

From: Jonathan Cameron
Date: Sun Nov 06 2022 - 12:36:57 EST


On Sun, 6 Nov 2022 00:34:22 +0200
Yauhen Kharuzhy <jekhor@xxxxxxxxx> wrote:

> Some devices has two sets of accelerometers and the sensor hub exports
> two hinge angle 'sensors' based on accelerometer values. To allow more
> than one sensor of the same type, use PLATFORM_DEVID_AUTO instead of
> PLATFORM_DEVID_NONE when registering platform device for it.
>
> Checked on the Lenovo Yoga Book YB1-X91L tablet.
>
> Signed-off-by: Yauhen Kharuzhy <jekhor@xxxxxxxxx>

Purely for curiosity sake, but where are the two sets of sensors?
Doesn't look like it has two hinges at first glance!

Jonathan

> ---
> drivers/hid/hid-sensor-custom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c
> index 32c2306e240d6..a6fc89ee1287c 100644
> --- a/drivers/hid/hid-sensor-custom.c
> +++ b/drivers/hid/hid-sensor-custom.c
> @@ -862,7 +862,7 @@ hid_sensor_register_platform_device(struct platform_device *pdev,
> return ERR_PTR(-ENOMEM);
>
> custom_pdev = platform_device_register_data(pdev->dev.parent, dev_name,
> - PLATFORM_DEVID_NONE, hsdev,
> + PLATFORM_DEVID_AUTO, hsdev,
> sizeof(*hsdev));
> kfree(dev_name);
> return custom_pdev;