Re: [PATCH v2 3/3] staging: rtl8192e: remove unnecesscary macro defines

From: Joe Perches
Date: Sat Nov 05 2022 - 21:19:00 EST


On Sun, 2022-11-06 at 12:11 +1100, Jacob Bai wrote:
> remove useless macro defines
[]
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> index eabb4187d907..aad1842857c0 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> @@ -307,12 +307,12 @@ void rtl92e_config_mac(struct net_device *dev)
> struct r8192_priv *priv = rtllib_priv(dev);
>
> if (priv->bTXPowerDataReadFromEEPORM) {
> - dwArrayLen = MACPHY_Array_PGLength;
> - pdwArray = Rtl819XMACPHY_Array_PG;
> + dwArrayLen = RTL8192E_MAC_ARRAY_PG_LEN;
> + pdwArray = RTL8192E_MAC_ARRAY_PG;

Perhaps use ARRAY_SIZE instead.