Re: [PATCH 2/2] soc: qcom: Add Qualcomm Ramp Controller driver

[Krzysztof Kozlowski]

On 04/11/2022 10:24, AngeloGioacchino Del Regno wrote:
> Il 04/11/22 15:22, Krzysztof Kozlowski ha scritto:
>> On 04/11/2022 10:18, AngeloGioacchino Del Regno wrote:
>>> Il 04/11/22 15:04, Krzysztof Kozlowski ha scritto:
>>>> On 04/11/2022 09:35, AngeloGioacchino Del Regno wrote:
>>>>> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
>>>>>
>>>>> The Ramp Controller is used to program the sequence ID for pulse
>>>>> swallowing, enable sequence and linking sequence IDs for the CPU
>>>>> cores on some Qualcomm SoCs.
>>>>>
>>>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
>>>>> ---
>>>>>    drivers/soc/qcom/Kconfig           |   9 +
>>>>>    drivers/soc/qcom/Makefile          |   1 +
>>>>>    drivers/soc/qcom/ramp_controller.c | 330 +++++++++++++++++++++++++++++
>>>>>    3 files changed, 340 insertions(+)
>>>>>    create mode 100644 drivers/soc/qcom/ramp_controller.c
>>>>>
>>>>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>>>>> index 024e420f1bb7..1e681f98bad4 100644
>>>>> --- a/drivers/soc/qcom/Kconfig
>>>>> +++ b/drivers/soc/qcom/Kconfig
>>>>> @@ -95,6 +95,15 @@ config QCOM_QMI_HELPERS
>>>>>    	tristate
>>>>>    	depends on NET
>>>>>    
>>>>> +config QCOM_RAMP_CTRL
>>>>> +	tristate "Qualcomm Ramp Controller driver"
>>>>> +	depends on ARCH_QCOM
>>>>
>>>> I propose:
>>>> depends on ARCH_QCOM && ARM || COMPILE_TEST
>>>>
>>>> I don't think it is used on ARM64 SoCs, so let's make life of distros
>>>> easier.
>>>
>>> Forgot to reply to this one: MSM8956 and MSM8976 are ARM64 SoCs :-)
>>
>> Yeah, indeed, I meant the other way around, so && ARM&64 :)
>>
> 
> I went too fast and sent out a v2 with ARCH_QCOM || COMPILE_TEST....
> ....should I go for a v3?

Wait a bit to collect feedback and then go with v3.


Best regards,
Krzysztof