Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock

From: Krzysztof Kozlowski
Date: Fri Nov 04 2022 - 09:55:24 EST


On 04/11/2022 05:00, Inbaraj wrote:
> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
>
> This fixes make dtbs_check warning as shown below:
>
> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-controller@17040000:
> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected
> From schema: /home/inbaraj/mainline/linux/Documentation/devicetree/
> bindings/clock/samsung,exynosautov9-clock.yaml

I don't understand:
1. Why bindings are wrong not DTSI?
2. What is "gout"? "dout" had a meaning as clock divider output.

>
> Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for cmu_fsys0/1")
> Signed-off-by: Inbaraj <inbaraj.e@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/clock/samsung,exynosautov9-clock.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
> index 2ab4642679c0..55c4f94a14d1 100644
> --- a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
> @@ -148,7 +148,7 @@ allOf:
> items:
> - const: oscclk
> - const: dout_clkcmu_fsys1_bus
> - - const: dout_clkcmu_fsys1_mmc_card
> + - const: gout_clkcmu_fsys1_mmc_card
> - const: dout_clkcmu_fsys1_usbdrd
>
> - if:

Best regards,
Krzysztof