Re: [PATCH 1/2] dt-bindings: rockchip: Add Rockchip rk3566 box demo board

[Krzysztof Kozlowski]

On 04/11/2022 08:38, Andy Yan wrote:
> Add device tree binding for Rockchip rk3566 box demo board.
> 
> Signed-off-by: Andy Yan <andyshrk@xxxxxxx>
> ---
> 
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 244c42eaae8c..618c78fb9d5e 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -754,6 +754,11 @@ properties:
>            - const: rockchip,rk3568-evb1-v10
>            - const: rockchip,rk3568
>  
> +      - description: Rockchip RK3566 BOX Evaluation Demo board

This does not look ordered by name or SoC number.

> +        items:
> +          - const: rockchip,rk3566-box-demo
> +          - const: rockchip,rk3566
> +
>        - description: Rockchip RK3568 Banana Pi R2 Pro
>          items:
>            - const: rockchip,rk3568-bpi-r2pro

Best regards,
Krzysztof