Re: [v2 01/13] x86/microcode/intel: Prevent printing updated microcode rev multiple times

From: Borislav Petkov
Date: Fri Nov 04 2022 - 07:01:41 EST


On Thu, Nov 03, 2022 at 05:58:49PM +0000, Ashok Raj wrote:
> @@ -696,8 +697,7 @@ static int collect_cpu_info(int cpu_num, struct cpu_signature *csig)
>
> csig->rev = c->microcode;
>
> - /* No extra locking on prev, races are harmless. */
> - if (csig->sig != prev.sig || csig->pf != prev.pf || csig->rev != prev.rev) {
> + if (bsp && csig->rev != prev.rev) {

This basically means that the loader is not going to support mixed
steppings microcode.

Yes, no?

If yes, can I remove the patch cache too and use a single buffer for the
current patch?

That would simplify things even more.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette