RE: [PATCH v2 tty-next 3/3] 8250: microchip: pci1xxxx: Add power management functions to quad-uart driver.

From: Tharunkumar.Pasumarthi
Date: Fri Nov 04 2022 - 06:24:04 EST


> From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Sent: Monday, October 3, 2022 2:57 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@xxxxxxxxxxxxx>
> Subject: Re: [PATCH v2 tty-next 3/3] 8250: microchip: pci1xxxx: Add power
> management functions to quad-uart driver.
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> If you have similarities with 8250_pci, probably you need to split it to
> 8250_pcilib.c and share. (See how 8250_dw /8250_lpss are done in that
> sense.)

Hi Andy,
All the functions used in 8250_pci1xxxx.c that have similarity with 8250_pci use registers
that are specific to our IP. The only function that can be moved to common library is the
setup_port. But, for that the first argument of setup_port must be changed to
'struct pci_dev *dev' (priv->dev). Do you suggest doing this?

Thanks,
Tharun Kumar P