Re: [PATCH v10 3/4] arm64: dts: qcom: sc7280: Add touchscreen and touchpad support for evoker

[Konrad Dybcio]

On 04/11/2022 07:19, Sheng-Liang Pan wrote:
> Change touchpad and touchscreen node for evoker
> Touchpad: SA461D-1011
> Touchscreen: GT7986U

What's the reasoning? Were they changed post r0? Is r0 support 
effectively dropped?

The changes look ok, but I feel like this needs more of a comment in the 
commit msg.


Konrad

> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
>
> Changes in v8:
> - updated patch subjects
>
> Changes in v7:
> - add compiatable for gt7986
>
> Changes in v6:
> - add removed pinctrl and align touchscreen label with herobrine board
>
> Changes in v5:
> - new patch for Touchscreen/trackpad in v5
>
>   .../boot/dts/qcom/sc7280-herobrine-evoker.dtsi    | 15 +++++++--------
>   1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
> index a6015491c6082..706dd82a70138 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
> @@ -23,16 +23,15 @@ ap_tp_i2c: &i2c0 {
>   	status = "okay";
>   	clock-frequency = <400000>;
>   
> -	trackpad: trackpad@2c {
> -		compatible = "hid-over-i2c";
> -		reg = <0x2c>;
> +	trackpad: trackpad@15 {
> +		compatible = "elan,ekth3000";
> +		reg = <0x15>;
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&tp_int_odl>;
>   
>   		interrupt-parent = <&tlmm>;
>   		interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
>   
> -		hid-descr-addr = <0x20>;
>   		vcc-supply = <&pp3300_z1>;
>   
>   		wakeup-source;
> @@ -43,9 +42,9 @@ ts_i2c: &i2c13 {
>   	status = "okay";
>   	clock-frequency = <400000>;
>   
> -	ap_ts: touchscreen@10 {
> -		compatible = "elan,ekth6915";
> -		reg = <0x10>;
> +	ap_ts: touchscreen@5d {
> +		compatible = "goodix,gt7986u", "goodix,gt7375p";
> +		reg = <0x5d>;
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&ts_int_conn>, <&ts_rst_conn>;
>   
> @@ -54,7 +53,7 @@ ap_ts: touchscreen@10 {
>   
>   		reset-gpios = <&tlmm 54 GPIO_ACTIVE_LOW>;
>   
> -		vcc33-supply = <&ts_avdd>;
> +		vdd-supply = <&ts_avdd>;
>   	};
>   };
>