Re: [PATCH] crypto/hisilicon: Add null judgment to the callback interface

From: Herbert Xu
Date: Fri Nov 04 2022 - 05:09:20 EST


On Sat, Oct 29, 2022 at 09:25:18AM +0800, liulongfang wrote:
>
> The context of the problem may not have been clearly stated in the previous
> description.
>
> This is a problem found in one of our real user scenarios:
> In this scenario of using an accelerator to perform encryption services,
> it was originally intended to use the CPU to perform encryption services
> in synchronous mode (without loading the hardware device driver, and without
> registering the asynchronous callback function), but due to a deployment
> error, the Hisi hardware device driver was loaded into the system,
> this wrong operation causes the encryption service to call the device
> driver of the hisi hardware, but the hardware device driver executes the
> asynchronous mode, so the callback interface is called after the service
> is completed.
> This leads to this system calltrace problem.
>
> The purpose of this patch is to ensure that the device does not appear
> calltrace in this abnormal situation.

I'm still having trouble understanding this. Please give an
exact call-trace that triggers the callback with a NULL callback
pointer.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt