Re: [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string

[Krzysztof Kozlowski]

On 03/11/2022 19:06, Fabrizio Castro wrote:
> s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency.
> 
> renesas,i2c-r9a09g011 is not actually used by the driver, therefore
> changing this doesn't cause any harm.

And what about other users of DTS? One chosen driver implementation
might not be enough...

> 
> Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C controller")

You need to explain the bug - where is the issue, how it affects users.
Otherwise it is not a bug and there is nothing to fix.


> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> index c46378efc123..92e899905ef8 100644
> --- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> @@ -16,7 +16,7 @@ properties:
>    compatible:
>      items:
>        - enum:
> -          - renesas,i2c-r9a09g011  # RZ/V2M
> +          - renesas,r9a09g011-i2c  # RZ/V2M

No.

Deprecate instead old compatible. There are already users of it, at
least in kernel. Not sure about other OS/bootloaders/firmwares.

Best regards,
Krzysztof