Re: [RESEND PATCH v2] kvm: x86: Keep the lock order consistent

From: Sean Christopherson
Date: Thu Nov 03 2022 - 19:15:47 EST


Nit, capitalize KVM in the shortlog, i.e. "KVM: x86:".

On Mon, Oct 31, 2022, Hao Peng wrote:
> From: Peng Hao <flyingpeng@xxxxxxxxxxx>
>
> Acquire SRCU before taking the gpc spinlock in wait_pending_event() so as
> to be consistent with all other functions that acquire both locks. It's
> not illegal to acquire SRCU inside a spinlock, nor is there deadlock
> potential, but in general it's preferable to order locks from least
> restrictive to most restrictive, e.g. if wait_pending_event() needed to
> sleep for whatever reason, it could do so while holding SRCU, but would
> need to drop the spinlock.

Extra whitespace at the beginning of each line should be deleted.

> Thanks Sean Christopherson for the comment.
>
> Signed-off-by: Peng Hao <flyingpeng@xxxxxxxxxxx>
> ---

Nits aside,

Reviewed-by: Sean Christopherson <seanjc@xxxxxxxxxx>