Re: [PATCH -next 2/2] PM: hibernate: add check of preallocate mem for image size pages

[Rafael J. Wysocki]

On Tue, Nov 1, 2022 at 3:28 AM TGSP <tgsp002@xxxxxxxxx> wrote:
>
> From: xiongxin <xiongxin@xxxxxxxxxx>
>
> Added a check on the return value of preallocate_image_highmem(). If
> memory preallocate is insufficient, S4 cannot be done;
>
> I am playing 4K video on a machine with AMD or other graphics card and
> only 8GiB memory, and the kernel is not configured with CONFIG_HIGHMEM.
> When doing the S4 test, the analysis found that when the pages get from
> minimum_image_size() is large enough, The preallocate_image_memory() and
> preallocate_image_highmem() calls failed to obtain enough memory. Add
> the judgment that memory preallocate is insufficient;

So I'm not sure what the problem is.  Can you please explain it in more detail?

The if (pages < alloc) appears to be false in your case, so there
should be enough free pages to create an image.

Maybe reserved_size is too low?