Re: [PATCH] cpufreq: longhaul: Make array speeds static const
From: Colin King (gmail)
Date: Thu Nov 03 2022 - 10:30:26 EST
On 03/11/2022 14:15, Joe Perches wrote:
On Thu, 2022-11-03 at 13:21 +0000, Colin Ian King wrote:
Don't populate the read-only array speeds on the stack but instead
make it static. Also makes the object code a little smaller.
[]
diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c
[]
@@ -407,7 +407,7 @@ static int guess_fsb(int mult)
{
int speed = cpu_khz / 1000;
int i;
- int speeds[] = { 666, 1000, 1333, 2000 };
+ static const int speeds[] = { 666, 1000, 1333, 2000 };
int f_max, f_min;
for (i = 0; i < 4; i++) {
style trivia: the loop test is probably better using ARRAY_SIZE
for (i = 0; i < ARRAY_SIZE(speeds); i++)
I'll send a V2 for that. Good idea.
Colin