Re: [PATCH 3/4] iommu/exynos: Modularize the driver
From: Sam Protsenko
Date: Thu Nov 03 2022 - 09:05:12 EST
Hi Marek,
[snip]
> MODULE_DEVICE_TABLE(of, sysmmu_of_match); is missing, so the driver
> won't be automatically loaded, what breaks its operation if compiled as
> module.
>
Right, didn't think about hot-plug case. Will add
MODULE_DEVICE_TABLE() along with MODULE_ALIAS() in v2, thanks.
> Also Exynos DRM and S5P-MFC drivers rely on the Exynos IOMMU being
> built-in, so they need to be adjusted for modularized builds too imho,
> at least in the Kconfig dependency.
>
Sure, I'll check all Kconfigs and defconfigs before sending out v2.
Btw, can you please also check my most recent reply [1] for the
"[PATCH 1/2] iommu/exynos: Abstract getting the fault info"?
[1] https://lore.kernel.org/lkml/CAPLW+4n-Lf6je61rxdJ9nJnX9h9F8F-y+qikG7eFF0avQpMV9Q@xxxxxxxxxxxxxx/
Thanks!
[snip]