Re: [PATCH] drm_bridge: register content protect property

From: CK Hu (胡俊光)
Date: Thu Nov 03 2022 - 01:46:26 EST


Hi, Hsin-Yi:

On Wed, 2022-11-02 at 13:37 +0800, CK Hu wrote:
> Hi, Hsin-Yi:
>
> On Tue, 2022-10-11 at 18:18 +0800, Hsin-Yi Wang wrote:
> > Some bridges are able to update HDCP status from userspace requests
> > if
> > they support HDCP.
> >
> > HDCP property is the same as other connector properties that need
> > to
> > be
> > created after the connecter is initialized and before the connector
> > is
> > registered.
>
> So this is anx7625 support HDCP, right?
> All connector with anx7625 has this problem, so I think this should
> be
> done in drm core not in each SoC driver.

I misunderstanding this patch, so just ignore my comment.

Regards,
CK

>
> Regards,
> CK
>
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/drm_bridge_connector.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_bridge_connector.c
> > b/drivers/gpu/drm/drm_bridge_connector.c
> > index 1c7d936523df5..a3b9ef8dc3f0b 100644
> > --- a/drivers/gpu/drm/drm_bridge_connector.c
> > +++ b/drivers/gpu/drm/drm_bridge_connector.c
> > @@ -7,6 +7,7 @@
> > #include <linux/module.h>
> > #include <linux/slab.h>
> >
> > +#include <drm/display/drm_hdcp_helper.h>
> > #include <drm/drm_atomic_state_helper.h>
> > #include <drm/drm_bridge.h>
> > #include <drm/drm_bridge_connector.h>
> > @@ -398,6 +399,8 @@ struct drm_connector
> > *drm_bridge_connector_init(struct drm_device *drm,
> > if (panel_bridge)
> > drm_panel_bridge_set_orientation(connector,
> > panel_bridge);
> >
> > + drm_connector_attach_content_protection_property(connector,
> > true);
> > +
> > return connector;
> > }
> > EXPORT_SYMBOL_GPL(drm_bridge_connector_init);