Re: [PATCH] qed (gcc13): use u16 for fid to be big enough

From: patchwork-bot+netdevbpf
Date: Wed Nov 02 2022 - 23:50:43 EST


Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Mon, 31 Oct 2022 12:43:54 +0100 you wrote:
> gcc 13 correctly reports overflow in qed_grc_dump_addr_range():
> In file included from drivers/net/ethernet/qlogic/qed/qed.h:23,
> from drivers/net/ethernet/qlogic/qed/qed_debug.c:10:
> drivers/net/ethernet/qlogic/qed/qed_debug.c: In function 'qed_grc_dump_addr_range':
> include/linux/qed/qed_if.h:1217:9: error: overflow in conversion from 'int' to 'u8' {aka 'unsigned char'} changes value from '(int)vf_id << 8 | 128' to '128' [-Werror=overflow]
>
> We do:
> u8 fid;
> ...
> fid = vf_id << 8 | 128;
>
> [...]

Here is the summary with links:
- qed (gcc13): use u16 for fid to be big enough
https://git.kernel.org/netdev/net-next/c/7d84118229bf

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html