Re: [PATCH 1/4] dt-bindings: reset: document Odroid Go Ultra power-off

[Rob Herring]

On Mon, Oct 31, 2022 at 05:47:25PM +0100, Neil Armstrong wrote:
> The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
> to its two PMICs in order, this represents the poweroff scheme needed to complet
> a clean poeroff of the system.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---
>  .../reset/hardkernel,odroid-go-ultra-poweroff.yaml | 42 ++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml
> new file mode 100644
> index 000000000000..65e42258717c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Hardkernel Odroid Go Ultra poweroff
> +
> +maintainers:
> +  - Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> +
> +description:
> +  The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
> +  to its two PMICs in order, this represents the poweroff scheme needed to complete
> +  a clean poeroff of the system.

You don't really need a node for this. Test against the top level 
compatible and then find the PMIC nodes by their compatible strings.

> +
> +properties:
> +  compatible:
> +    const: hardkernel,odroid-go-ultra-poweroff
> +
> +  hardkernel,rk817-pmic:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: Phandle to the RK817 PMIC node
> +
> +  hardkernel,rk818-pmic:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: Phandle to the RK818 PMIC node
> +
> +required:
> +  - compatible
> +  - hardkernel,rk817-pmic
> +  - hardkernel,rk818-pmic
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    poweroff {
> +        compatible = "hardkernel,odroid-go-ultra-poweroff";
> +        hardkernel,rk817-pmic = <&rk817>;
> +        hardkernel,rk818-pmic = <&rk818>;
> +    };
> 
> -- 
> b4 0.10.1
>