Re: [PATCH 2/3] bindings: pm8941-misc: rename misc node name

[Luca Weiss]

Hi Neil,

On Mittwoch, 2. November 2022 11:35:55 CET Neil Armstrong wrote:
> Hi,
> 
> On 31/10/2022 18:57, Luca Weiss wrote:
> > The spmi-pmic bindings is now using usb-detect@ for this node, so adjust
> > the example to match.
> 
> Subject should be:
> dt-bindings: pm8941-misc: rename misc node name
> instead of:
> bindings: pm8941-misc: rename misc node name

Also here I've followed the style of the previous commits to this file

4fcdd677c4ea bindings: pm8941-misc: Add support for VBUS detection
dd6f5afb1c2d bindings: pm8941-misc: Convert bindings to YAML

Though it seems other commits in this directory recently have used
"dt-bindings: extcon: " prefix. Do you still want me to change it?

Regards
Luca

> 
> > Signed-off-by: Luca Weiss <luca@xxxxxxxxx>
> > ---
> > 
> >   Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml
> > b/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml index
> > 6a9c96f0352a..fbda899fd260 100644
> > --- a/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml
> > +++ b/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml
> > 
> > @@ -49,7 +49,7 @@ examples:
> >               interrupt-controller;
> >               #interrupt-cells = <4>;
> > 
> > -            usb_id: misc@900 {
> > +            usb_id: usb-detect@900 {
> > 
> >                       compatible = "qcom,pm8941-misc";
> >                       reg = <0x900>;
> >                       interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>;
> 
> With subject fixed:
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>