Re: [PATCH] media: stv0288: use explicitly signed char

[Jason A. Donenfeld]

Hi Mauro,

On Mon, Oct 24, 2022 at 6:28 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
>
> With char becoming unsigned by default, and with `char` alone being
> ambiguous and based on architecture, signed chars need to be marked
> explicitly as such. Use `s8` and `u8` types here, since that's what
> surrounding code does. This fixes:
>
> drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: assigning (-9) to unsigned variable 'tm'
> drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: we never enter this loop
>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Cc: linux-media@xxxxxxxxxxxxxxx
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>

Was wondering whether you planned on taking this into your tree as a
6.1 fix for Linus for rc4?

Thanks,
Jason