Re: [v2 1/3] dt-bindings: Add bindings for aspeed pwm-tach.

From: Rob Herring
Date: Tue Nov 01 2022 - 14:40:47 EST


On Tue, Nov 01, 2022 at 05:51:54PM +0800, Billy Tsai wrote:
> This patch adds device binding for aspeed pwm-tach device which is a
> multi-function device include pwm and tach function and pwm/tach device
> bindings which should be the child-node of pwm-tach device.
>
> Signed-off-by: Billy Tsai <billy_tsai@xxxxxxxxxxxxxx>
> ---
> .../bindings/hwmon/aspeed,ast2600-tach.yaml | 48 ++++++++++++
> .../bindings/mfd/aspeed,ast2600-pwm-tach.yaml | 76 +++++++++++++++++++
> .../bindings/pwm/aspeed,ast2600-pwm.yaml | 64 ++++++++++++++++
> 3 files changed, 188 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2600-tach.yaml
> create mode 100644 Documentation/devicetree/bindings/mfd/aspeed,ast2600-pwm-tach.yaml
> create mode 100644 Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml

I'm pretty sure I've said this before, but I'm not taking more fan
controller bindings without comming up with a common binding. Please see
this series[1] and help ensure it meets your needs.

Rob

[1] https://lore.kernel.org/all/20221013094838.1529153-2-Naresh.Solanki@xxxxxxxxxxxxx/