RE: [EXT] Re: [PATCH v14 2/7] PCI: endpoint: pci-epf-vntb: Fix indentation of the struct epf_ntb_ctrl

[Frank Li]

> -----Original Message-----
> From: Manivannan Sadhasivam <mani@xxxxxxxxxx>
> Sent: Tuesday, November 1, 2022 6:56 AM
> To: Frank Li <frank.li@xxxxxxx>
> Cc: allenbh@xxxxxxxxx; bhelgaas@xxxxxxxxxx; dave.jiang@xxxxxxxxx;
> helgaas@xxxxxxxxxx; imx@xxxxxxxxxxxxxxx; jdmason@xxxxxxxx;
> kw@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
> lpieralisi@xxxxxxxxxx; ntb@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v14 2/7] PCI: endpoint: pci-epf-vntb: Fix
> indentation of the struct epf_ntb_ctrl
> 
> Caution: EXT Email
> 
> On Fri, Oct 28, 2022 at 11:56:58AM -0400, Frank Li wrote:
> > From: Frank Li <frank.li@xxxxxxx>
> >
> > Indentation of the struct epf_ntb_ctrl align with other struct
> >
> 
> "Align the indentation of struct epf_ntb_ctrl with other structs in the driver"
> 
> > Signed-off-by: Frank Li <frank.li@xxxxxxx>
> > ---
> >  drivers/pci/endpoint/functions/pci-epf-vntb.c | 28 +++++++++----------
> >  1 file changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > index c0115bcb3b5e..1863006cc36c 100644
> > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > @@ -99,20 +99,20 @@ enum epf_ntb_bar {
> >   *       NTB Driver               NTB Driver
> >   */
> >  struct epf_ntb_ctrl {
> > -     u32     command;
> > -     u32     argument;
> > -     u16     command_status;
> > -     u16     link_status;
> > -     u32     topology;
> > -     u64     addr;
> > -     u64     size;
> > -     u32     num_mws;
> > -     u32     reserved;
> > -     u32     spad_offset;
> > -     u32     spad_count;
> > -     u32     db_entry_size;
> > -     u32     db_data[MAX_DB_COUNT];
> > -     u32     db_offset[MAX_DB_COUNT];
> > +     u32 command;
> > +     u32 argument;
> > +     u16 command_status;
> > +     u16 link_status;
> > +     u32 topology;
> > +     u64 addr;
> > +     u64 size;
> > +     u32 num_mws;
> > +     u32 reserved;
> > +     u32 spad_offset;
> > +     u32 spad_count;
> > +     u32 db_entry_size;
> > +     u32 db_data[MAX_DB_COUNT];
> > +     u32 db_offset[MAX_DB_COUNT];
> 
> General question: Don't we need to take care of endianess here?

[Frank Li] you are right. But it is out of scope of this patch. 
We can add it later.

> 
> Thanks,
> Mani
> 
> >  } __packed;
> >
> >  struct epf_ntb {
> > --
> > 2.34.1
> >
> 
> --
> மணிவண்ணன் சதாசிவம்