Re: [PATCH] Input: edt-ft5x06 - replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

[Oliver Graute]

> Am 01.11.2022 um 09:14 schrieb Bo Liu <liubo03@xxxxxxxxxx>:
> 
> Fix the following coccicheck warning:
>  drivers/input/touchscreen/edt-ft5x06.c:756:0-23: WARNING:
>    debugfs_mode_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
> 
> Signed-off-by: Bo Liu <liubo03@xxxxxxxxxx>

Reviewed-by: Oliver Graute <oliver.graute@xxxxxxxxxxxxxxxxx>

> ---
> drivers/input/touchscreen/edt-ft5x06.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index 9ac1378610bc..a184425b6985 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -753,7 +753,7 @@ static int edt_ft5x06_debugfs_mode_set(void *data, u64 mode)
> 	return retval;
> };
> 
> -DEFINE_SIMPLE_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get,
> +DEFINE_DEBUGFS_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get,
> 			edt_ft5x06_debugfs_mode_set, "%llu\n");
> 
> static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file,
> -- 
> 2.27.0
>