Re: [PATCH] ath11k: Fix QCN9074 firmware boot on x86

From: Kalle Valo
Date: Tue Nov 01 2022 - 10:46:34 EST


"Tyler J. Stachecki" <stachecki.tyler@xxxxxxxxx> writes:

> The 2.7.0 series of QCN9074's firmware requests 5 segments
> of memory instead of 3 (as in the 2.5.0 series).
>
> The first segment (11M) is too large to be kalloc'd in one
> go on x86 and requires piecemeal 1MB allocations, as was
> the case with the prior public firmware (2.5.0, 15M).
>
> Since f6f92968e1e5, ath11k will break the memory requests,
> but only if there were fewer than 3 segments requested by
> the firmware. It seems that 5 segments works fine and
> allows QCN9074 to boot on x86 with firmware 2.7.0, so
> change things accordingly.
>
> Signed-off-by: Tyler J. Stachecki <stachecki.tyler@xxxxxxxxx>

Ouch, that's pretty bad. Thanks for fixing this!

Does the 2.5.0.1 firmware branch still work with this patch? It's
important that we don't break the old firmware.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches