[PATCH v2 1/7] staging: wlan-ng: Remove unused struct wlan_ie_ssid references

From: Deepak R Varma
Date: Tue Nov 01 2022 - 09:48:27 EST


Pointer reference to struct wlan_ie_ssid is added as a member variable
to 5 different structures. However, these references are never used.
Remove such unused struct references. The cleanup also renders the
struct useless; so remove it as well.
Issue identified as part of coccicheck based code analysis.

Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Suggested-by: Pavel Skripkin <paskripkin@xxxxxxxxx>
Signed-off-by: Deepak R Varma <drv@xxxxxxxxx>
---

Changes in v2:
1. Include additional code clean-up opportunities and combine changes in a
patch set based on impact areas.
2. The patch changes are compile tested only on X86 arch.


drivers/staging/wlan-ng/p80211mgmt.h | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h
index 1ef30d3f3159..dcff56d18498 100644
--- a/drivers/staging/wlan-ng/p80211mgmt.h
+++ b/drivers/staging/wlan-ng/p80211mgmt.h
@@ -225,13 +225,6 @@ struct wlan_ie {
u8 len;
} __packed;

-/*-- Service Set Identity (SSID) -----------------*/
-struct wlan_ie_ssid {
- u8 eid;
- u8 len;
- u8 ssid[1]; /* may be zero, ptrs may overlap */
-} __packed;
-
/*-- Supported Rates -----------------------------*/
struct wlan_ie_supp_rates {
u8 eid;
@@ -319,7 +312,6 @@ struct wlan_fr_beacon {
u16 *bcn_int;
u16 *cap_info;
/*-- info elements ----------*/
- struct wlan_ie_ssid *ssid;
struct wlan_ie_supp_rates *supp_rates;
struct wlan_ie_fh_parms *fh_parms;
struct wlan_ie_ds_parms *ds_parms;
@@ -372,7 +364,6 @@ struct wlan_fr_assocreq {
u16 *cap_info;
u16 *listen_int;
/*-- info elements ----------*/
- struct wlan_ie_ssid *ssid;
struct wlan_ie_supp_rates *supp_rates;

};
@@ -407,7 +398,6 @@ struct wlan_fr_reassocreq {
u16 *listen_int;
u8 *curr_ap;
/*-- info elements ----------*/
- struct wlan_ie_ssid *ssid;
struct wlan_ie_supp_rates *supp_rates;

};
@@ -439,7 +429,6 @@ struct wlan_fr_probereq {
void *priv;
/*-- fixed fields -----------*/
/*-- info elements ----------*/
- struct wlan_ie_ssid *ssid;
struct wlan_ie_supp_rates *supp_rates;

};
@@ -457,7 +446,6 @@ struct wlan_fr_proberesp {
u16 *bcn_int;
u16 *cap_info;
/*-- info elements ----------*/
- struct wlan_ie_ssid *ssid;
struct wlan_ie_supp_rates *supp_rates;
struct wlan_ie_fh_parms *fh_parms;
struct wlan_ie_ds_parms *ds_parms;
--
2.34.1