Re: Aw: Re: [PATCH v2 1/2] dt-bindings: PCI: mediatek-gen3: add SoC based clock config

[Jianjun Wang (王建军)]

Hi Frank,

On Fri, 2022-10-28 at 18:42 +0200, Frank Wunderlich wrote:
> Hi
> > Gesendet: Freitag, 28. Oktober 2022 um 11:24 Uhr
> > Von: "Jianjun Wang" <jianjun.wang@xxxxxxxxxxxx>
> > An: "Frank Wunderlich" <linux@xxxxxxxxx>, 
> > linux-mediatek@xxxxxxxxxxxxxxxxxxx
> > Cc: "Frank Wunderlich" <frank-w@xxxxxxxxxxxxxxx>, "Ryder Lee" <
> > ryder.lee@xxxxxxxxxxxx>, "Bjorn Helgaas" <bhelgaas@xxxxxxxxxx>,
> > "Rob Herring" <robh+dt@xxxxxxxxxx>, "Krzysztof Kozlowski" <
> > krzysztof.kozlowski+dt@xxxxxxxxxx>, "Matthias Brugger" <
> > matthias.bgg@xxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, 
> > devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, 
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, "Rob Herring" <
> > robh@xxxxxxxxxx>
> > Betreff: Re: [PATCH v2 1/2] dt-bindings: PCI: mediatek-gen3: add
> > SoC based clock config
> > 
> > Hi Frank,
> > 
> > After apply this patch, we found some dtbs_check error with the
> > following patch which adds the PCIe node for MT8195:
> > 
> > 
https://lore.kernel.org/linux-pci/20221020111925.30002-3-tinghan.shen@xxxxxxxxxxxx/
> > 
> > arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb: 
> > pcie@112f0000
> > : clock-names:        5: 'top_133m' was expected
> >     From schema: Documentation/devicetree/bindings/pci/mediatek-
> > pcie-
> > gen3.yaml
> > arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb: 
> > pcie@112f8000
> > : clock-names:        5: 'top_133m' was expected
> >     From schema: Documentation/devicetree/bindings/pci/mediatek-
> > pcie-
> > gen3.yaml
> > 
> > Did you get the same error when adding the PCIe node for MT7986?
> 
> i'm sure i had tested the yaml and did not get any error, but on my
> retest i get same error for mt7986 too...
> 
> maybe the right way is to remove the contains in the mediatek,mt8192-
> pcie if condition (to match only if this condition is no fallback),
> then it is clean for me. Can you test it with your patches?

Sorry for the late response, I have tested with the patch for MT8195,
and it works, thanks!

> 
> allOf:
>   - $ref: /schemas/pci/pci-bus.yaml#
>   - if:
>       properties:
>         compatible:
>           #contains:
>           const: mediatek,mt8192-pcie
>     then:
>       properties:
>         clock-names:
>           items:
>             - const: pl_250m
>             - const: tl_26m
>             - const: tl_96m
>             - const: tl_32k
>             - const: peri_26m
>             - const: top_133m
> 
> 
> regards Frank
> 
> regards Frank