Re: [PATCH v2] usb: cdnsp: Fix wrong transmission direction of EP0

From: Greg KH
Date: Tue Nov 01 2022 - 01:08:47 EST


On Tue, Nov 01, 2022 at 12:44:33PM +0800, Jing Leng wrote:
> EP0 transfer is bi-directional, but in the cdnsp gadget, the
> transmission direction of EP0 is not changed after it is
> initialized to IN, so the OUT data from EP0 received by the host
> is invalid.
>
> The value of ep0_expect_in will change according to the value of
> bRequestType in the SETUP transaction of control transfer, so we
> can use it as the transmission direction of EP0.
>
> Signed-off-by: Jing Leng <3090101217@xxxxxxxxxx>
> Signed-off-by: Jing Leng <jleng@xxxxxxxxxxxxx>
> ---
> ChangeLog v1->v2:
> - Rebase the patch.
> - Make email addresses ('From' and 'Signed-off-by') consistent.

That didn't happen. You list yourself twice, and the last one does not
match the From: line on the patch.

Also the verification did not even work showing that this is an invalid
email from 3090101217@xxxxxxxxxx, so I can't trust it at all.

Please fix up your email system to properly send email from
ambarella.com with the correct verification.

thanks,

greg k-h