Re: Re: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops

From: Russell King (Oracle)
Date: Sun Oct 23 2022 - 16:10:15 EST


On Sun, Oct 23, 2022 at 09:21:37PM +0200, Frank Wunderlich wrote:
> > Gesendet: Sonntag, 23. Oktober 2022 um 21:03 Uhr
> > Von: "Frank Wunderlich" <frank-w@xxxxxxxxxxxxxxx>
>
> > if you fix this typo you can send the patch and add my tested-by:
> >
> > regmap_read(mpcs->regmap, SGMSYS_SGMII_MODE, &val);
> > - if (interface = == PHY_INTERFACE_MODE_SGMII)
> > + if (interface == PHY_INTERFACE_MODE_SGMII)
> > val |= SGMII_IF_MODE_BIT0;
> > else
> > val &= ~SGMII_IF_MODE_BIT0;
> >
> > should i send an update for my patch including this:
> >
> > state->duplex = DUPLEX_FULL;
> >
> > or do you want to read the duplex from the advertisement like stated before?
> >
> > regmap_read(mpcs->regmap, SGMSYS_PCS_CONTROL_1, &bm);
> > regmap_read(mpcs->regmap, SGMSYS_PCS_CONTROL_1 + 8, &adv);
> >
> > phylink_mii_c22_pcs_decode_state(state, bm >> 16, adv >> 16);
>
> with the phylink-helper it works too
>
> https://github.com/frank-w/BPI-R2-4.14/commits/6.1-r3-sgmii2

This is amazingly great news - we now know how to configure this
hardware! Let me cook up a proper set of patches for tomorrow - if
that's okay.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!