Re: [PATCH] net/mptcp: fix repeated words in comments

From: Bagas Sanjaya
Date: Sun Oct 23 2022 - 09:47:10 EST


On Sat, Oct 22, 2022 at 03:05:27PM +0800, wangjianli wrote:
> Delete the redundant word 'the'.
>
> Signed-off-by: wangjianli <wangjianli@xxxxxxxxxx>
> ---
> net/mptcp/token.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mptcp/token.c b/net/mptcp/token.c
> index f52ee7b26aed..b817c2564300 100644
> --- a/net/mptcp/token.c
> +++ b/net/mptcp/token.c
> @@ -287,7 +287,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock);
> * This function returns the first mptcp connection structure found inside the
> * token container starting from the specified position, or NULL.
> *
> - * On successful iteration, the iterator is move to the next position and the
> + * On successful iteration, the iterator is move to the next position and
> * the acquires a reference to the returned socket.
> */
> struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot,

NAK!

Instead, slightly reword the comment above as "On successful iteration,
the iterator moves to the next position and acquires a reference to the
returned socket.".

Also, you and other @cdjrlc.com developers ignore reviews that request
changes to your patches. If you want to participate in kernel
development community, please don't just sending random patches without
any sort of reply.

I have pointed out this behavior either as part of my review or as reply
to reviews from other developers. I may write this as final warning before
I just say NAK without further ado to your future patches.

Thanks.

--
An old man doll... just what I always wanted! - Clara

Attachment: signature.asc
Description: PGP signature