Re: [PATCH][Resend] rhashtable: make test actually random

From: Herbert Xu
Date: Sat Oct 22 2022 - 00:14:54 EST


On Fri, Oct 21, 2022 at 03:47:03PM +0200, Rolf Eike Beer wrote:
> The "random rhlist add/delete operations" actually wasn't very random, as all
> cases tested the same bit. Since the later parts of this loop depend on the
> first case execute this unconditionally, and then test on different bits for the
> remaining tests. While at it only request as much random bits as are actually
> used.
>
> Signed-off-by: Rolf Eike Beer <eike-kernel@xxxxxxxxx>
> ---
> lib/test_rhashtable.c | 58 ++++++++++++++++---------------------------
> 1 file changed, 22 insertions(+), 36 deletions(-)

Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt