Re: [PATCH v6 0/8] libsas and drivers: NCQ error handling

From: Martin K. Petersen
Date: Fri Oct 21 2022 - 23:52:51 EST


On Mon, 17 Oct 2022 17:20:27 +0800, John Garry wrote:

> As reported in [0], the pm8001 driver NCQ error handling more or less
> duplicates what libata does in link error handling, as follows:
> - abort all commands
> - do autopsy with read log ext 10 command
> - reset the target to recover, if necessary
>
> Indeed for the hisi_sas driver we want to add similar handling for NCQ
> errors.
>
> [...]

Applied to 6.2/scsi-queue, thanks!

[1/8] scsi: libsas: Add sas_ata_device_link_abort()
https://git.kernel.org/mkp/scsi/c/44112922674b
[2/8] scsi: hisi_sas: Move slot variable definition in hisi_sas_abort_task()
https://git.kernel.org/mkp/scsi/c/4b329abc9180
[3/8] scsi: hisi_sas: Add SATA_DISK_ERR bit handling for v3 hw
https://git.kernel.org/mkp/scsi/c/930d97dabdd5
[4/8] scsi: hisi_sas: Modify v3 HW SATA disk error state completion processing
https://git.kernel.org/mkp/scsi/c/4ef4f1a61555
[5/8] scsi: pm8001: Modify task abort handling for SATA task
https://git.kernel.org/mkp/scsi/c/0b639decf651
[6/8] scsi: pm8001: Use sas_ata_device_link_abort() to handle NCQ errors
https://git.kernel.org/mkp/scsi/c/811be570a9a8
[7/8] scsi: libsas: Make sas_{alloc, alloc_slow, free}_task() private
https://git.kernel.org/mkp/scsi/c/8e8d43642f2f
[8/8] scsi: libsas: Update SATA dev FIS in sas_ata_task_done()
https://git.kernel.org/mkp/scsi/c/cc22efbec011

--
Martin K. Petersen Oracle Linux Engineering