Re: [PATCH v4 0/7] scsi: libsas: Use request tag in more drivers

From: Martin K. Petersen
Date: Fri Oct 21 2022 - 23:11:12 EST



John,

> All other libsas drivers manage the tags internally. Tag management in
> pm8001 and mvsas is currently using a simple bitmap, so use the
> request tag when available there. With this change we still need to
> manage tags for libsas "internal" commands, like SMP commands, and any
> other private commands so reserve some tags for this:

> - For pm8001 I went with pre-existing and unused PM8001_RESERVE_SLOT
> size. The value is 8, which should be enough. It is greater than
> mvsas, below, but this driver sends a lot of other private commands to
> HW.
> - For mvsas I went with 4, which still should be enough.
>
> isci and aic9xx have elaborate tag alloc schemes, so I'm not going to
> bother changing them, especially since I have no HW to test with.
>
> Helper sas_task_find_rq() is added to get the request and associated
> tag per sas_task when it is available.

Applied to 6.2/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering