Re: [PATCH] mm/page_isolation: fix clang deadcode warning

From: Andrew Morton
Date: Fri Oct 21 2022 - 00:17:46 EST


On Fri, 21 Oct 2022 11:26:22 +0800 "Aiqun(Maria) Yu" <quic_aiquny@xxxxxxxxxxx> wrote:

> > Honestly, the cure is worse than the disease. I'd rather not have a
> > line that's this long.
> I don't like this long either. While the current Deadcode warning is
> also annoying for our clang tidy check.
>
> will the CONFIG check can be acceptable?
> like:
> #ifdef CONFIG_DEBUG_VM
> or
> if (IS_ENABLED(CONFIG_DEBUG_VM))
>
> Any good ideas?

Put a newline in there?

Although the shortly following lines are nearly as long...