Re: [RFC PATCH v2 0/4] hwmon: (jc42) regmap conversion and resume fix

From: Guenter Roeck
Date: Thu Oct 20 2022 - 18:16:54 EST


On Thu, Oct 20, 2022 at 11:03:16PM +0200, Martin Blumenstingl wrote:
> Hello,
>
> this is a follow-up to the comments I got from Guenter on v1 of my patch
> from [0] titled:
> "hwmon: (jc42) Restore the min/max/critical temperatures on resume"
> There Guenter suggested: "The best solution would probably be to convert
> the driver to use regmap and let regmap handle the caching". That's the
> goal of this series - in addition to fixing the original resume issue
> (see patch #3 - which was the reason for v1 of this series).
>
> Changes since v1 at [0]:
> - marked as RFC
> - added patches for regmap (patch #1) and regcache (patch #2) conversion
> - patch #3 has been updated to use regcache for restoring the register
> values during system resume (this was originally patch 1/1)
> - added another patch to remove caching of the temperature register
>


Great, excellent work. As mentioned in the patches, please combine
patches 1, 2, and 4 into a single patch. Also, drop the RFC.

Thanks,
Guenter