Re: [PATCH 1/1] kernel/utsname_sysctl.c: Add missing enum uts_proc value

From: Greg Kroah-Hartman
Date: Thu Oct 20 2022 - 11:55:45 EST


On Thu, Oct 20, 2022 at 05:06:45PM +0200, Petr Vorel wrote:
> bfca3dd3d068 added new struct ctl_table uts_kern_table[], but not new
> enum uts_proc value. It broke the notification mechanism between the
> sethostname syscall and the pollers of /proc/sys/kernel/hostname.
>
> The table uts_kern_table is addressed within uts_proc_notify by the enum
> value, that's why new enum value is needed.
>
> Fixes: bfca3dd3d068 ("kernel/utsname_sysctl.c: print kernel arch")
>
> Reported-by: Torsten Hilbrich <torsten.hilbrich@xxxxxxxxxxx>
> Signed-off-by: Petr Vorel <pvorel@xxxxxxx>
> ---
> Hi all,
>
> I'm sorry to introduce a regression.
>
> Torsten Hilbrich reported [1] that hostnamectl set-hostname foo
> which does poll() got affected by bfca3dd3d068. He also wrote a
> reproducer [2] which does not require systemd, I tested the patch on
> dracut initramfs.

Thanks for the quick response, I'll queue this up in my tree now.

greg k-h