Re: [PATCH v3] wifi: rt2x00: use explicitly signed or unsigned types

From: Kalle Valo
Date: Thu Oct 20 2022 - 06:36:21 EST


Stanislaw Gruszka <stf_xl@xxxxx> writes:

> On Wed, Oct 19, 2022 at 09:55:41AM -0600, Jason A. Donenfeld wrote:
>> On some platforms, `char` is unsigned, but this driver, for the most
>> part, assumed it was signed. In other places, it uses `char` to mean an
>> unsigned number, but only in cases when the values are small. And in
>> still other places, `char` is used as a boolean. Put an end to this
>> confusion by declaring explicit types, depending on the context.
>>
>> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>> Cc: Stanislaw Gruszka <stf_xl@xxxxx>
>> Cc: Helmut Schaa <helmut.schaa@xxxxxxxxxxxxxx>
>> Cc: Kalle Valo <kvalo@xxxxxxxxxx>
>> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
>
> Acked-by: Stanislaw Gruszka <stf_xl@xxxxx>

Thanks, I'll queue this to v6.1.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches