Re: [PATCH v3 2/2] spi: meson-spicc: Use pinctrl to drive CLK line when idle

[Neil Armstrong]

On 19/10/2022 22:50, Martin Blumenstingl wrote:
> Hi Amjad,
>
> On Wed, Oct 19, 2022 at 4:03 PM Amjad Ouled-Ameur
> <aouledameur@xxxxxxxxxxxx> wrote:
> [...]
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> > index c3ac531c4f84..04e9d0f1bde0 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> > @@ -429,6 +429,20 @@ mux {
> >                          };
> >                  };
> >
> > +               spi_idle_high_pins: spi-idle-high-pins {
> > +                       mux {
> > +                               groups = "spi_sclk";
> > +                               bias-pull-up;
> > +                       };
> > +               };
> > +
> > +               spi_idle_low_pins: spi-idle-low-pins {
> > +                       mux {
> > +                               groups = "spi_sclk";
> > +                               bias-pull-down;
> > +                       };
> > +               };
> > +
> We typically have the .dts{,i} changes in a separate patch. I suggest
> doing the same here.
> I also have two questions about this part:
> - why are these not referenced by the SPICC controller node?

Because it's up to the board to use or not those states, if some pull-up/downs
are already present on the lines no need to use those special states.

> - is there a particular reason why meson-gxl.dtsi is updated but
> meson-gxbb.dtsi is not? (my understanding is that GXBB is also lacking
> hardware OEN support)

Good question indeed, so indeed they should be added in meson-gxbb.dtsi in a separate patch.
> Best regards,
> Martin

Thanks,
Neil