Re: [PATCH] rtc: rtc-cmos: Fix wake alarm breakage

From: Alexandre Belloni
Date: Wed Oct 19 2022 - 14:16:52 EST


On 19/10/2022 18:13:43+0200, Rafael J. Wysocki wrote:
> On Tue, Oct 18, 2022 at 6:39 PM Alexandre Belloni
> <alexandre.belloni@xxxxxxxxxxx> wrote:
> >
> > On Tue, 18 Oct 2022 18:09:31 +0200, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > >
> > > Commit 4919d3eb2ec0 ("rtc: cmos: Fix event handler registration
> > > ordering issue") overlooked the fact that cmos_do_probe() depended
> > > on the preparations carried out by cmos_wake_setup() and the wake
> > > alarm stopped working after the ordering of them had been changed.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] rtc: rtc-cmos: Fix wake alarm breakage
> > commit: 0782b66ed2fbb035dda76111df0954515e417b24
>
> Thank you!
>
> However, there is a build fix on top of this which has just been posted:
>
> https://lore.kernel.org/linux-acpi/2677035.mvXUDI8C0e@kreacher/
>
> Sorry about breaking it again.

I had that in rtc-fixes:

https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-fixes


--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com