[PATCH 4/5] x86/microcode: Do some minor fixups

From: Borislav Petkov
Date: Wed Oct 19 2022 - 13:54:54 EST


From: Borislav Petkov <bp@xxxxxxx>

Improve debugging printks and fixup formatting.

Signed-off-by: Borislav Petkov <bp@xxxxxxx>
---
arch/x86/kernel/cpu/microcode/core.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
index 8401b7235a68..6b025143b073 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -568,6 +568,8 @@ static int mc_cpu_starting(unsigned int cpu)
{
enum ucode_state err = microcode_ops->apply_microcode(cpu);

+ pr_debug("%s: CPU%d, err: %d\n", __func__, cpu, err);
+
return err == UCODE_ERROR;
}

@@ -590,7 +592,7 @@ static int mc_cpu_down_prep(unsigned int cpu)

/* Suspend is in progress, only remove the interface */
sysfs_remove_group(&dev->kobj, &mc_attr_group);
- pr_debug("CPU%d removed\n", cpu);
+ pr_debug("%s: CPU%d\n", __func__, cpu);

return 0;
}
@@ -639,14 +641,11 @@ static int __init microcode_init(void)
if (!microcode_ops)
return -ENODEV;

- microcode_pdev = platform_device_register_simple("microcode", -1,
- NULL, 0);
+ microcode_pdev = platform_device_register_simple("microcode", -1, NULL, 0);
if (IS_ERR(microcode_pdev))
return PTR_ERR(microcode_pdev);

- error = sysfs_create_group(&cpu_subsys.dev_root->kobj,
- &cpu_root_microcode_group);
-
+ error = sysfs_create_group(&cpu_subsys.dev_root->kobj, &cpu_root_microcode_group);
if (error) {
pr_err("Error creating microcode group!\n");
goto out_pdev;
--
2.35.1