Re: [PATCH v3 1/2] spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states

From: Krzysztof Kozlowski
Date: Wed Oct 19 2022 - 10:44:51 EST


On 19/10/2022 10:01, Amjad Ouled-Ameur wrote:
> SPI pins of the SPICC Controller in Meson-GX needs to be controlled by
> pin biais when idle. Therefore define three pinctrl names:
> - default: SPI pins are controlled by spi function.
> - idle-high: SCLK pin is pulled-up, but MOSI/MISO are still controlled
> by spi function.
> - idle-low: SCLK pin is pulled-down, but MOSI/MISO are still controlled
> by spi function.
>


> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - amlogic,meson-gx-spicc
> +
> + then:
> + properties:
> + pinctrl-names:
> + minItems: 1
> + items:
> + - const: default
> + - const: idle-high
> + - const: idle-low

You should also define in such case pinctrl-0 and others.

Best regards,
Krzysztof