Re: [PATCH -next] drm/amd/display: make dcn32_mmhubbub_funcs static

From: Harry Wentland
Date: Wed Oct 19 2022 - 09:41:33 EST




On 2022-10-19 02:31, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mmhubbub.c:214:28:
> warning: symbol 'dcn32_mmhubbub_funcs' was
> not declared. Should it be static?
>
> Signed-off-by: ruanjinjie <ruanjinjie@xxxxxxxxxx>

Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>

Harry

> ---
> drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> index 41b0baf8e183..c3b089ba511a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> @@ -211,7 +211,7 @@ static void mmhubbub32_config_mcif_arb(struct mcif_wb *mcif_wb,
> REG_UPDATE(MCIF_WB_ARBITRATION_CONTROL, MCIF_WB_CLIENT_ARBITRATION_SLICE, params->arbitration_slice);
> }
>
> -const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
> +static const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
> .warmup_mcif = mmhubbub32_warmup_mcif,
> .enable_mcif = mmhubbub2_enable_mcif,
> .disable_mcif = mmhubbub2_disable_mcif,