Re: [PATCHv10 10/15] x86/mm, iommu/sva: Make LAM and SVM mutually exclusive

From: Ashok Raj
Date: Tue Oct 18 2022 - 19:59:19 EST


On Wed, Oct 19, 2022 at 01:35:37AM +0300, Kirill A. Shutemov wrote:
> > >
> > > /* Uprobes on this MM assume 32-bit code */
> > > -#define MM_CONTEXT_UPROBE_IA32 BIT(0)
> > > +#define MM_CONTEXT_UPROBE_IA32 BIT(0)
> > > /* vsyscall page is accessible on this MM */
> > > -#define MM_CONTEXT_HAS_VSYSCALL BIT(1)
> > > +#define MM_CONTEXT_HAS_VSYSCALL BIT(1)
> >
> > Nit: Looks like the two above format changes got in here :-)
>
> That's side effect of keeping the new longer flag aligned to the rest.
>
> A separate patch looks like an overkill, no?

Agree, just thought i'll flag it, but I don't think a new patch is
required.