Re: [PATCH] wifi: rt2x00: use explicitly signed type for clamping

From: Andrew Morton
Date: Tue Oct 18 2022 - 17:07:42 EST


On Tue, 18 Oct 2022 14:27:34 -0600 "Jason A. Donenfeld" <Jason@xxxxxxxxx> wrote:

> On some platforms, `char` is unsigned, which makes casting -7 to char
> overflow, which in turn makes the clamping operation bogus. Instead,
> deal with an explicit `s8` type, so that the comparison is always
> signed, and return an s8 result from the function as well. Note that
> this function's result is assigned to a `short`, which is always signed.

Thanks. I'll grab this for now to make -next happier. Stephen will
tell us when the patch (or one like it) appears via the wireless tree.