Re: [PATCH 0/5] fsi: Add regmap and refactor sbefifo

[Eddie James]

On 10/17/22 12:37, Mark Brown wrote:
> On Fri, Oct 14, 2022 at 05:05:35PM -0500, Eddie James wrote:
> > The SBEFIFO hardware can now be attached over a new I2C endpoint
> > interface called the I2C Responder (I2CR). In order to use the
> > existing SBEFIFO driver, add regmap drivers for both FSI busses
> > and the I2CR. Then, refactor the SBEFIFO and OCC drivers to clean
> > up and use the new regmap drivers.
> Is there any great reason to provide support in the regmap core for this
> rather than just implementing in drivers/fsi?  AFAICT this is just
> ending up as an implementation detail of shared code in drivers/fsi and
> won't have any external users?


One reason is to have a common interface with the new FSI regmap. That 
way abstracting out the bus transfer is trivial in the new SBEFIFO 
driver, assuming the SBEFIFO driver should switch to use the FSI regmap.

But you are correct, I doubt anyone else will use this. I suppose 
SBEFIFO may as well not use the regmap and just use some callbacks for 
whichever bus transfer...


Thanks,

Eddie