Re: [akpm-mm:mm-unstable 76/100] mm/ksm.c:423:5: warning: no previous prototype for 'break_ksm_pud_entry'

[David Hildenbrand]

On 18.10.22 12:53, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
> head:   f5938bbbb79d48ca167e305c228dccbecea0309e
> commit: 268ae2f9f2a7303079739cb975348a8ede4cda1d [76/100] mm/ksm: convert break_ksm() to use walk_page_range_vma()
> config: arc-randconfig-r043-20221017
> compiler: arceb-elf-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?id=268ae2f9f2a7303079739cb975348a8ede4cda1d
>          git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git
>          git fetch --no-tags akpm-mm mm-unstable
>          git checkout 268ae2f9f2a7303079739cb975348a8ede4cda1d
>          # save the config file
>          mkdir build_dir && cp config build_dir/.config
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> All warnings (new ones prefixed by >>):
>
> > > mm/ksm.c:423:5: warning: no previous prototype for 'break_ksm_pud_entry' [-Wmissing-prototypes]
>       423 | int break_ksm_pud_entry(pud_t *pud, unsigned long addr, unsigned long next,
>           |     ^~~~~~~~~~~~~~~~~~~
> > > mm/ksm.c:432:5: warning: no previous prototype for 'break_ksm_pmd_entry' [-Wmissing-prototypes]
>       432 | int break_ksm_pmd_entry(pmd_t *pmd, unsigned long addr, unsigned long next,
>           |     ^~~~~~~~~~~~~~~~~~~

Right, both should be static. I'll be sending an updated patch set that 
removes break_ksm_pud_entry soonish (busy doing all kinds of other stuff).

--
Thanks,

David / dhildenb