Re: [PATCH v3] arm64: dts: qcom: pmi8998: add rradc node

From: konrad . dybcio
Date: Mon Oct 17 2022 - 15:14:35 EST


On 2022-10-17 21:09, Caleb Connolly wrote:
Add a DT node for the Round Robin ADC found in the PMI8998 PMIC.

The RRADC reports PMIC die and skin temperatures, as well as
battery/charger thermals. It also reports USB and DC charger voltage and
current measurements.

Signed-off-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx>
---
This patch introduces a new dtbs_check warning which will be fixed by
https://lore.kernel.org/linux-arm-msm/20221017185105.2279129-1-caleb.connolly@xxxxxxxxxx/

V2:
https://lore.kernel.org/linux-arm-msm/20221017185609.2280067-1-caleb.connolly@xxxxxxxxxx/
Changes since v2:
* Remove 'status = "okay";'

V1:
https://lore.kernel.org/linux-arm-msm/20221016180330.1912214-1-caleb.connolly@xxxxxxxxxx/
Changes since v1:
* Change node name from adc@ to rradc@, see linked patch
* Enable the RRADC by default, rather than per-device
---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>

Konrad
arch/arm64/boot/dts/qcom/pmi8998.dtsi | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
index 6d3d212560c1..08c9ec2cafa6 100644
--- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
@@ -18,6 +18,12 @@ pmi8998_gpio: gpios@c000 {
interrupt-controller;
#interrupt-cells = <2>;
};
+
+ pmi8998_rradc: rradc@4500 {
+ compatible = "qcom,pmi8998-rradc";
+ reg = <0x4500>;
+ #io-channel-cells = <1>;
+ };
};

pmi8998_lsid1: pmic@3 {